Async generator (#613)

Change parser to accept async generator. Closes #612.
swc-project · Jan 29, 2020 · d06eeed · d06eeed
1 parent 480015d
commit d06eeed
Show file tree

Hide file tree

Showing 5 changed files with 97 additions and 3 deletions.
diff --git a/ecmascript/parser/src/parser/class_and_fn.rs b/ecmascript/parser/src/parser/class_and_fn.rs
@@ -760,9 +760,9 @@ impl<'a, I: Tokens> Parser<'a, I> {
         let is_generator = {
             let start = cur_pos!();
             if eat!('*') {
-                if is_async {
-                    syntax_error!(span!(start), SyntaxError::AsyncGenerator {});
-                }
+                // if is_async {
+                //     syntax_error!(span!(start), SyntaxError::AsyncGenerator {});
+                // }
                 true
             } else {
                 false

diff --git a/ecmascript/parser/tests/jsx/basic/custom/issue-612-async-generator/issue.js b/ecmascript/parser/tests/jsx/basic/custom/issue-612-async-generator/issue.js
@@ -0,0 +1 @@
+async function* agf() {}
diff --git a/ecmascript/parser/tests/jsx/basic/custom/issue-612-async-generator/issue.js.json b/ecmascript/parser/tests/jsx/basic/custom/issue-612-async-generator/issue.js.json
@@ -0,0 +1,46 @@
+{
+  "type": "Module",
+  "span": {
+    "start": 0,
+    "end": 24,
+    "ctxt": 0
+  },
+  "body": [
+    {
+      "type": "FunctionDeclaration",
+      "identifier": {
+        "type": "Identifier",
+        "span": {
+          "start": 16,
+          "end": 19,
+          "ctxt": 0
+        },
+        "value": "agf",
+        "typeAnnotation": null,
+        "optional": false
+      },
+      "declare": false,
+      "params": [],
+      "decorators": [],
+      "span": {
+        "start": 0,
+        "end": 24,
+        "ctxt": 0
+      },
+      "body": {
+        "type": "BlockStatement",
+        "span": {
+          "start": 22,
+          "end": 24,
+          "ctxt": 0
+        },
+        "stmts": []
+      },
+      "generator": true,
+      "async": true,
+      "typeParameters": null,
+      "returnType": null
+    }
+  ],
+  "interpreter": null
+}
diff --git a/ecmascript/parser/tests/typescript/custom/issue-612-async-generator/input.ts b/ecmascript/parser/tests/typescript/custom/issue-612-async-generator/input.ts
@@ -0,0 +1 @@
+async function* agf() {}
diff --git a/ecmascript/parser/tests/typescript/custom/issue-612-async-generator/input.ts.json b/ecmascript/parser/tests/typescript/custom/issue-612-async-generator/input.ts.json
@@ -0,0 +1,46 @@
+{
+  "type": "Module",
+  "span": {
+    "start": 0,
+    "end": 24,
+    "ctxt": 0
+  },
+  "body": [
+    {
+      "type": "FunctionDeclaration",
+      "identifier": {
+        "type": "Identifier",
+        "span": {
+          "start": 16,
+          "end": 19,
+          "ctxt": 0
+        },
+        "value": "agf",
+        "typeAnnotation": null,
+        "optional": false
+      },
+      "declare": false,
+      "params": [],
+      "decorators": [],
+      "span": {
+        "start": 0,
+        "end": 24,
+        "ctxt": 0
+      },
+      "body": {
+        "type": "BlockStatement",
+        "span": {
+          "start": 22,
+          "end": 24,
+          "ctxt": 0
+        },
+        "stmts": []
+      },
+      "generator": true,
+      "async": true,
+      "typeParameters": null,
+      "returnType": null
+    }
+  ],
+  "interpreter": null
+}