Skip to content

Commit

Permalink
chore(scripts): Use cargo profile instruments instead of `cargo ins…
Browse files Browse the repository at this point in the history
…truments` (#3086)
  • Loading branch information
kdy1 authored Dec 21, 2021
1 parent 4c1948f commit d482d61
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
4 changes: 4 additions & 0 deletions crates/swc/scripts/instrument.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/usr/bin/env bash
set -eu

cargo profile instruments --release -t time --bench typescript --features concurrent,tracing/release_max_level_info $@
2 changes: 1 addition & 1 deletion crates/swc_bundler/scripts/instrument.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env bash
set -eu

cargo instruments --release -t time --example bundle --features concurrent,tracing/release_max_level_info -- $@
cargo profile instruments --release -t time --example bundle --features concurrent,tracing/release_max_level_info -- $@
2 changes: 1 addition & 1 deletion crates/swc_ecma_codegen/scripts/instrument.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env bash
set -eu

cargo instruments --release -t time --example gen --features tracing/release_max_level_info -- $@
cargo profile instruments --release -t time --example gen --features tracing/release_max_level_info -- $@
2 changes: 1 addition & 1 deletion crates/swc_ecma_minifier/scripts/instrument.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env bash
set -eu

cargo instruments --release -t time --open --features tracing/release_max_level_info --example perf -- $@
cargo profile instruments --release -t time --open --features tracing/release_max_level_info --example perf -- $@
2 changes: 1 addition & 1 deletion crates/swc_ecma_parser/scripts/instrument.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env bash
set -eu

cargo instruments --release -t time --features log/release_max_level_info --example perf
cargo profile instruments --release -t time --features log/release_max_level_info --example perf
4 changes: 0 additions & 4 deletions scripts/instrument.sh

This file was deleted.

1 comment on commit d482d61

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: d482d61 Previous: 4c1948f Ratio
full_es2015 168609349 ns/iter (± 15694735) 216743845 ns/iter (± 8327564) 0.78
full_es2016 141486733 ns/iter (± 24849178) 180407795 ns/iter (± 7438183) 0.78
full_es2017 147015676 ns/iter (± 18536459) 187232923 ns/iter (± 10177988) 0.79
full_es2018 159168187 ns/iter (± 17543070) 186815606 ns/iter (± 9282565) 0.85
full_es2019 158095098 ns/iter (± 9147086) 183742573 ns/iter (± 14718298) 0.86
full_es2020 156832369 ns/iter (± 6951721) 183652384 ns/iter (± 22341679) 0.85
full_es3 219823227 ns/iter (± 10648526) 256824023 ns/iter (± 15553524) 0.86
full_es5 199301270 ns/iter (± 7954940) 233767939 ns/iter (± 17754501) 0.85
parser 699021 ns/iter (± 23590) 804829 ns/iter (± 17121) 0.87

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.