fix(es/transforms/compat): Fix block scoping of class declarations (#…

…1569)
swc-project · Apr 14, 2021 · d8a18df · d8a18df
1 parent df2a926
commit d8a18df
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/ecmascript/transforms/base/src/resolver/mod.rs b/ecmascript/transforms/base/src/resolver/mod.rs
@@ -1245,6 +1245,9 @@ impl VisitMut for Hoister<'_, '_> {
     }
 
     fn visit_mut_class_decl(&mut self, node: &mut ClassDecl) {
+        if self.in_block {
+            return;
+        }
         self.resolver.in_type = false;
         self.resolver
             .visit_mut_binding_ident(&mut node.ident, Some(VarDeclKind::Let));

diff --git a/ecmascript/transforms/base/src/resolver/tests.rs b/ecmascript/transforms/base/src/resolver/tests.rs
@@ -2646,3 +2646,31 @@ to!(
     })();
     "#
 );
+
+to!(
+    block_scope_class,
+    r#"
+    const g = 20;
+
+    function baz() {
+        {
+            class g {}
+            console.log(g);
+        }
+
+        return g;
+    }
+    "#,
+    r#"
+    const g = 20;
+
+    function baz() {
+        {
+            class g1 {}
+            console.log(g1);
+        }
+
+        return g;
+    }
+    "#
+);