fix(webpack/ast): Fix amd support (#2959)

swc_webpack_ast:
 - `ast_reducer`: Preserve array literals in `define` calls.

crates/swc_webpack_ast/Cargo.toml

@@ -5,7 +5,7 @@ edition = "2018"
 license = "Apache-2.0"
 name = "swc_webpack_ast"
 repository = "https://github.com/swc-project/swc.git"
-version = "0.3.1"
+version = "0.3.2"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 

crates/swc_webpack_ast/src/reducer.rs

@@ -200,7 +200,7 @@ struct ReduceAst {
 
     can_remove_pat: bool,
     preserve_fn: bool,
-    preserve_lit: bool,
+    is_string_lit_important: bool,
 
     changed: bool,
 }
@@ -600,11 +600,11 @@ impl VisitMut for ReduceAst {
                     // We should preserve the arguments if the callee is not invalid.
                     let old_preserver_fn = self.preserve_fn;
                     self.preserve_fn = !callee.is_fn_expr() && !callee.is_arrow();
-                    let old_preserve_lit = self.preserve_lit;
-                    self.preserve_lit |= is_string_lit_important;
+                    let old_preserve_lit = self.is_string_lit_important;
+                    self.is_string_lit_important |= is_string_lit_important;
                     e.visit_mut_children_with(self);
 
-                    self.preserve_lit = old_preserve_lit;
+                    self.is_string_lit_important = old_preserve_lit;
                     self.preserve_fn = old_preserver_fn;
 
                     return;
@@ -614,11 +614,21 @@ impl VisitMut for ReduceAst {
             _ => {}
         }
 
-        if self.preserve_lit && e.is_lit() {
+        if self.is_string_lit_important && (e.is_lit() || e.is_array()) {
             return;
         }
 
-        e.visit_mut_children_with(self);
+        match e {
+            Expr::Fn(..) | Expr::Arrow(..) => {
+                let old = self.is_string_lit_important;
+                self.is_string_lit_important = false;
+                e.visit_mut_children_with(self);
+                self.is_string_lit_important = old;
+            }
+            _ => {
+                e.visit_mut_children_with(self);
+            }
+        }
 
         match e {
             Expr::Seq(seq) => {

crates/swc_webpack_ast/tests/fixture/amd/define-required/1/output.js

@@ -1,5 +1,7 @@
 export function foo() {
-    define("require", function(r) {
+    define([
+        "require"
+    ], function(r) {
         r("lodash");
     });
 }

crates/swc_webpack_ast/tests/fixture/css-escape/1/output.js

@@ -1,2 +1,2 @@
 if (null) module.exports;
-else if (define, define.amd) define(null, null);
+else if (define, define.amd) define([], null);

crates/swc_webpack_ast/tests/fixture/react-dom/dev/output.js

@@ -1 +1,4 @@
-module, require("react"), define, define.amd, define("react", null);
+module, require("react"), define, define.amd, define([
+    "exports",
+    "react"
+], null);

crates/swc_webpack_ast/tests/fixture/react-dom/prod/output.js

@@ -1 +1,4 @@
-module, require("react"), define, define.amd, define("react", null);
+module, require("react"), define, define.amd, define([
+    "exports",
+    "react"
+], null);