-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin system rewrite for swc and spack #1321
Comments
What format would the plugins take in
|
It should be string for now. In future, we may add support for javascript functions within |
{
"plugins": ["my-plugin"]
} The user would have this item in their "my-plugin": "x.x.x" And |
I think plugins should be written in plain javascript. The ast definition changes over time, and it means native binaries should be rebuilt frequently. It's bad for plugin users. |
I'm quite interested in spack as a replacement for webpack. I'll try looking into this, but I'm not familiar with this code base yet, so I might not be able. |
Are you guys working on this? |
I have not got far. I was only still reading about napi-rs.
Would be faster if you do it!
…On Thu, 14 Jan 2021 at 21:17, 강동윤 ***@***.***> wrote:
Are you guys working on this?
I'm asking this because I'm going to work on this if nobody is working on
it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1321 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMCUOPORUIALKMP3PILUMLSZ3VFJANCNFSM4VZ5HCOQ>
.
|
Yeah, I haven't gotten far either. I've managed to get |
Are there plans to support plugins written in Rust? |
@mischnic No. Managing two plugin APIs is too much for now. |
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
swc
We should
.swcrc
file.This requires calling js function from rust. See https://docs.rs/napi/1.1.1/napi/struct.JsFunction.html for apis for it.
We should create a
sync::channel
and call the stored js function javascript thread because the javascript function is notSend
norSync
.It can done by converting the ast of
swc
into the one of babel. As ast node of babel does not have methods, so converting to json using newtype structs will work.spack
Requirement is same as above.
I'm not sure how hard this will be.
The text was updated successfully, but these errors were encountered: