Plugin system rewrite for swc and spack

[kdy1]

swc

We should

• Allow specifying plugin in .swcrc file.

This requires calling js function from rust. See https://docs.rs/napi/1.1.1/napi/struct.JsFunction.html for apis for it.
We should create a sync::channel and call the stored js function javascript thread because the javascript function is not Send nor Sync.

• Support calling babel plugins

It can done by converting the ast of swc into the one of babel. As ast node of babel does not have methods, so converting to json using newtype structs will work.

spack

• Allow writing plugin with javascript

Requirement is same as above.

• Allow using webpack plugins.

I'm not sure how hard this will be.

[mfeckie]

What format would the plugins take in .swcrc?

{
  "plugins" [] // Array of strings? functions?
}

[kdy1]

@mfeckie

It should be string for now. In future, we may add support for javascript functions within .swcrc.js, just like babel.

[mfeckie]

{
  "plugins": ["my-plugin"]
}

The user would have this item in their package.json

  "my-plugin": "x.x.x"

And my-plugin would be built and published via napi-rs or would it be plain JS and napi-rs would only be used withing swc to make it callable?

[kdy1]

I think plugins should be written in plain javascript.

The ast definition changes over time, and it means native binaries should be rebuilt frequently. It's bad for plugin users.

[dwoznicki]

Allow using webpack plugins.

I'm quite interested in spack as a replacement for webpack. I'll try looking into this, but I'm not familiar with this code base yet, so I might not be able.

[kdy1]

Are you guys working on this?
I'm asking this because I'm going to work on this if nobody is working on it.

[mfeckie]

I have not got far. I was only still reading about napi-rs. Would be faster if you do it!

…

On Thu, 14 Jan 2021 at 21:17, 강동윤 ***@***.***> wrote: Are you guys working on this? I'm asking this because I'm going to work on this if nobody is working on it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1321 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMCUOPORUIALKMP3PILUMLSZ3VFJANCNFSM4VZ5HCOQ> .

[dwoznicki]

Yeah, I haven't gotten far either. I've managed to get bundle() to accept an array of plugin functions and execute them in Rust, but I'm still trying to figure out the internals of webpack's plugin system. Here's the small amount I've done so far, if it's any help.

[mischnic]

Are there plans to support plugins written in Rust?

[kdy1]

@mischnic No. Managing two plugin APIs is too much for now.

[swc-bot]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.