Skip to content

Support stage-4 ergonomic brand checks for private fields #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sosukesuzuki opened this issue Aug 12, 2021 · 5 comments · Fixed by #2079
Closed

Support stage-4 ergonomic brand checks for private fields #2064

sosukesuzuki opened this issue Aug 12, 2021 · 5 comments · Fixed by #2079
Milestone
v1.2.92

Comments

@sosukesuzuki
Copy link
Contributor

Describe the feature

Support ergonomic brand checks proposal that is now Stage-4.

Babel plugin or link to the feature description

Now Babel 7.15 supports it in default.

Additional context

Nothing
@sosukesuzuki sosukesuzuki changed the title Support stage-4 ergonomic brand checks Support stage-4 ergonomic brand checks for private fields Aug 12, 2021
@kdy1
Copy link
Member

kdy1 commented Aug 13, 2021

Thanks for the info!

@kdy1 kdy1 modified the milestones: v1.2.77, v1.2.78 Aug 13, 2021
@HiZhaoxiaoyang
Copy link

开始还以为shock wave component又卷土重来了。

@kdy1 kdy1 mentioned this issue Aug 14, 2021
Merged
@kdy1 kdy1 modified the milestones: v1.2.78, v1.2.79, v1.2.80, v1.2.81 Aug 16, 2021
@kdy1 kdy1 modified the milestones: v1.2.81, v1.2.82, v1.2.83, v1.2.84 Aug 24, 2021
@kdy1 kdy1 modified the milestones: v1.2.84, v1.2.85, v1.2.86 Sep 1, 2021
@kdy1 kdy1 modified the milestones: v1.2.86, v1.2.87, v1.2.88, v1.2.89 Sep 11, 2021
@kdy1 kdy1 removed this from the v1.2.89 milestone Sep 21, 2021
@kdy1 kdy1 modified the milestones: v1.2.90, v1.2.91, v1.2.92 Sep 21, 2021
@sosukesuzuki
Copy link
Contributor Author

Note; Ergonomic brand checks will be landed in TypeScript 4.5 😄
(Sorry if you know about this.)

@kdy1
Copy link
Member

kdy1 commented Sep 26, 2021

I didn't finish it because of time. It's stage-4, so support of tsc does not matter.

kdy1 added a commit that referenced this issue Sep 27, 2021
@kdy1
feat(es/parser, es/transform): Implement ergonomic brand checking (#2079
e46a842 
)

swc_ecma_parser:
 - Implement parsing of private properties in object literals.

swc_ecma_transforms_base:
 - `fixer`: Handle `const [a = (b, c)]`.

swc_ecma_transforms_compat:
 - `class_properties`: Support ergonomic brand checks. (#2064)

swc_ecma_transforms_proposal:
 - Implement ergonomic brand checks for private fields. (#2064)
@swc-bot
Copy link
Collaborator

swc-bot commented Oct 21, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
v1.2.92
Development

Successfully merging a pull request may close this issue.

feat(es/parser, es/transform): Implement ergonomic brand checking kdy1/swc
4 participants
@HiZhaoxiaoyang @sosukesuzuki @kdy1 @swc-bot