-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to get if a nested namespace does not have a declare keyword #623
Comments
@dsherret As declare module "@dsherret/package" {
declare namespace packageName {
}
} Results in error |
Yeah, I guess I could keep track of whether it's in a declare context or not. |
@dsherret I found a way to fix the issue. I'll fix it soon. |
Sweet. Thanks! No rush! Yeah, it seems like babel and typescript both don't mark those nodes as "declare". TypeScript does use some flags to say the node is in an ambient context though. |
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Describe the feature
A TsModuleDecl has
declare: true
when within a nested namespace.So this means there's no way to tell if there's a
declare
keyword on the nested namespace.Would it be possible to change the parser to only have
declare
on nodes that have a declare keyword?The text was updated successfully, but these errors were encountered: