Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minifier doesn't respect toString method in object when converting it to string value #8704

Closed
hyp3rflow opened this issue Mar 7, 2024 · 1 comment · Fixed by #8763
Closed
Assignees
Labels
Milestone

Comments

@hyp3rflow
Copy link
Contributor

hyp3rflow commented Mar 7, 2024

Describe the bug

When minifier converts object to string value, it should respect toString method in it.
Currently swc minifier doesn't respect it and always convert it to [object Object].

Input code

console.log({toString() {return 'swc'}} + '')

Config

No response

Playground link (or link to the minimal reproduction)

https://play.swc.rs/?version=1.4.6-nightly-20240307.1&code=H4sIAAAAAAAAA0vOzyvOz0nVy8lP16guyQ8uKcrMS9fQVKguSi0pLcpTUC8uT1avrVXQVlBX1wQAIjRpPC0AAAA%3D&config=H4sIAAAAAAAAA32UO3LjMAyG%2B5zCozrFjostcoDtcgYOTYIyvXxoCNCxJuO7L0TJj40hdRI%2B%2FAAJgPh%2B2%2B26E5ruY%2FfNn%2Fwz6IJQ7v9swTGRvrClAxM1muIH6t5v9IQTcjogNNN1Jh3p0gM1Fe5%2F7feLogs5I9wUiy365N34nNPkOBRAfLKxlUPWCInwf%2F3CSv6aAJX6bD%2FkHECnDaI0Kp8IeihSYJND0AOCOusiRJlOqovHLKWYYCWwaih5EHmynnxOnPOVWtBWmWxBQL6AIX8GSca5WJaQryfcp2ELh9r3rc8%2F1HDWoWoScsKltYRPK0Q9Zo%2BkXE1SCWe4UoMZLsX9qfROFaBa0qvulH1a6clfAK5A0IhJR5DiNg%2FH87SmdptKnxyPLI0C5%2FmWbpmg56Iq751Q2akyUMhL3Sxgq4GpskY6zoJXyofeggLneFaE0PjlyRylpDQOkJ0AuL%2FaSVM1A3V%2FhSt8ehAb%2BA%2FfkuQBWzyipuM6xTEecthIEIGO2W44cCsor%2BPCW%2BIyrPOaLPBogBVdKjbwugT4AVBWoe3Ll9ng58ERVR%2Fy4bEmFofrfQ9HnfrHe59X8dvi0MVsa4PLkp%2F6O6%2Fm393D6baF7wfvPH7elC3p9R%2BoYzQdMAYAAA%3D%3D

SWC Info output

No response

Expected behavior

console.log('swc')

or don't minify it.

Actual behavior

console.log("[object Object]");

Version

1.4.5

Additional context

No response

@hyp3rflow hyp3rflow added the C-bug label Mar 7, 2024
@kdy1 kdy1 added this to the Planned milestone Mar 7, 2024
@kdy1 kdy1 self-assigned this Mar 7, 2024
@kdy1 kdy1 removed their assignment Mar 12, 2024
@kdy1 kdy1 self-assigned this Mar 20, 2024
kdy1 added a commit that referenced this issue Mar 20, 2024
**Related issue:**

 - Closes #8704
 - Closes #8705
@kdy1 kdy1 modified the milestones: Planned, v1.4.11 Mar 27, 2024
@swc-bot
Copy link
Collaborator

swc-bot commented Apr 26, 2024

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

3 participants