Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript emitDecoratorMetadata support #919

Closed
Brooooooklyn opened this issue Jul 31, 2020 · 4 comments · Fixed by #939
Closed

TypeScript emitDecoratorMetadata support #919

Brooooooklyn opened this issue Jul 31, 2020 · 4 comments · Fixed by #939
Assignees
@kdy1
Milestone
v1.2.13

Comments

@Brooooooklyn
Copy link
Member

Relate issue: #666

I will try to implement this feature.
@kdy1 kdy1 modified the milestones: v1.2.11, v1.2.12, v1.2.13 Aug 1, 2020
@kdy1 kdy1 mentioned this issue Aug 6, 2020
Merged
@kdy1 kdy1 self-assigned this Aug 6, 2020
@kdy1
Copy link
Member

kdy1 commented Aug 6, 2020

Oh.. I missed your comment and I implemented it. Sorry.

@Brooooooklyn
Copy link
Member Author

@kdy1 oh doesn't matter, I have not started this yet 🌚

@kdy1 kdy1 closed this as completed in #939 Aug 6, 2020
kdy1 added a commit that referenced this issue Aug 6, 2020
@kdy1
Metadata for typescript decorator (#939)
0989e73 
swc_ecma_transforms:
 - Allow emitting decorator metadata (#666, #919)

swc:
 - change order of passes to allow decorator using type informations
@elliotaplant
Copy link

How does one use this feature? Do you need to do anything other than have emitDecoratorMetadata: true in your tsconfig.json?

@swc-bot
Copy link
Collaborator

swc-bot commented Oct 16, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.2.13
Development

Successfully merging a pull request may close this issue.

Metadata for typescript decorator kdy1/swc
4 participants
@Brooooooklyn @elliotaplant @kdy1 @swc-bot