-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
perf(es/parser): Inline skip_space
#11252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(es/parser): Inline skip_space
#11252
Conversation
🦋 Changeset detectedLatest commit: c841f00 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR changes the inlining hint for the skip_space method from #[inline(never)] to #[inline], allowing the compiler to inline this frequently-called method for better performance.
- Performance optimization by enabling inlining of the
skip_spacemethod
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Binary Sizes
Commit: e353c0a |
CodSpeed Performance ReportMerging #11252 will improve performances by 5.13%Comparing Summary
Benchmarks breakdown
Footnotes |
kdy1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
skip_spaceskip_space
Description:
I think it's worth to inline
skip_spaceafter #11225, which madeskip_spacesimple and short.