Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support windows ia32 arch #1367

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Support windows ia32 arch #1367

merged 1 commit into from
Jan 29, 2021
+105 −12

Conversation

Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn commented Jan 29, 2021 •
edited
Loading

Build and tests for node addons passed: https://github.com/swc-project/swc/actions/runs/519840643

Ready to merge

@Brooooooklyn Brooooooklyn marked this pull request as draft January 29, 2021 03:12
@Brooooooklyn Brooooooklyn marked this pull request as ready for review January 29, 2021 03:55
@Brooooooklyn Brooooooklyn changed the title Support windowx ia32 arch Support windows ia32 arch Jan 29, 2021
kdy1
kdy1 approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you a lot!

@kdy1 kdy1 added this to the v1.2.47 milestone Jan 29, 2021
@kdy1 kdy1 merged commit ca417e9 into swc-project:master Jan 29, 2021
@Brooooooklyn Brooooooklyn deleted the win-i686 branch January 29, 2021 06:15
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.47
Development

Successfully merging this pull request may close these issues.
2 participants
@Brooooooklyn @kdy1