Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/transforms/module): transform esmodule import to sequence expression #1561

Merged
merged 8 commits into from
Apr 13, 2021
Merged

fix(es/transforms/module): transform esmodule import to sequence expression #1561

merged 8 commits into from
Apr 13, 2021

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented Apr 9, 2021

Fixes #1556

@Austaras Austaras marked this pull request as ready for review April 11, 2021 10:46
@kdy1 kdy1 added this to the v1.2.53 milestone Apr 12, 2021
kdy1
kdy1 reviewed Apr 13, 2021
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.
I found one tiny problem, though.

ecmascript/transforms/react/src/refresh/mod.rs Show resolved Hide resolved
@kdy1 kdy1 merged commit df2a926 into swc-project:master Apr 13, 2021
@Zequez Zequez mentioned this pull request Apr 29, 2021
Open
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.53
Development

Successfully merging this pull request may close these issues.

Transform esmodule without break this
2 participants
@Austaras @kdy1