Don't replace missing object members with undefined #1567
Merged
+9
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general,
{}.foo
shouldn't be replaced withundefined
because{}.constructor
itself,{}.hasOwnProperty
, ...) and({}.__proto__).foo = 2; console.log({}.foo)
Instead, only member accesses for properties that actually exists should be replaced
The fix seems to work, but I'm not so sure about the added test: reverting the change to the simplifier, this is the test output:
shouldn't it say something like
Expected: '({}).foo', Actual: 'undefined'
?