Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/parser): Allow async in "TsAsExpression" #2395

Merged
merged 3 commits into from
Oct 10, 2021
Merged

fix(es/parser): Allow async in "TsAsExpression" #2395

merged 3 commits into from
Oct 10, 2021
+356 −3

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Oct 10, 2021

This PR allows the code below:

(async as any);
(async as async as async);
async as any;
async as async as async;

kdy1
kdy1 approved these changes Oct 10, 2021
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, although test cases seem ridiculous.

@kdy1 kdy1 added this to the v1.2.96 milestone Oct 10, 2021
@kdy1 kdy1 merged commit 4458f9c into swc-project:master Oct 10, 2021
@g-plane g-plane deleted the fix-async-with-as branch October 10, 2021 11:23
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.96
Development

Successfully merging this pull request may close these issues.
2 participants
@g-plane @kdy1