fix(es/transforms/cjs): Preserve order of imports for reexports #2598
+215
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for tackling this! I suspect the test cases for my recent merge ( |
kwonoj
force-pushed
the
fix-cjs-export-all-ordering
branch
from
03edc8a to
213a35e
Compare
Thanks, I tried to update test cases as well. |
kwonoj
force-pushed
the
fix-cjs-export-all-ordering
branch
from
213a35e to
34d8da1
Compare
kwonoj
force-pushed
the
fix-cjs-export-all-ordering
branch
from
34d8da1 to
4a1cede
Compare
kdy1
reviewed
Nov 1, 2021
|
This may possibly resolve #1733, too. |
kwonoj
force-pushed
the
fix-cjs-export-all-ordering
branch
from
5b16122 to
601aa9a
Compare
kwonoj
force-pushed
the
fix-cjs-export-all-ordering
branch
from
601aa9a to
3436fff
Compare
kwonoj
commented
Nov 2, 2021
kdy1
approved these changes
Nov 2, 2021
|
Appreciate for the review for both, @kdy1 and @JeremyGrieshop 🙇 |
kdy1
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to order of the imports / reexports in transpiled runtime codebase. #2594 itself sufficiently explains the issue itself. It could be an implementation detail but so far based on observation tsc / babel works in the same way, which makes think it'd better to align as well. As issue described normally this won't appear but if there's some sort of circular dependencies, or reexports have dependencies across each other it may reveal different behavior.
For the change itself, PR changes the order of injecting handled export_all stmt by putting it after require stmt is created. In result, export_all stmt doesn't use extra_stmt (which appends to stmt at the end). Also changed
exports_allsto map to stmt itself - when encountering ExportAll stmt it is gauranteed we'll need stmt anyway - hashmap contains generated stmt instead of only keeping name of export. This allowed easier lookup at the end.Lastly, I noticed there is prior test cases from #133 (https://github.com/swc-project/swc/pull/133/files#diff-6d08f604fc5444313bf8d80ca76a84f5abbc95129eb4e1311592637fbb17b089R1075) , looks like it is coming from original transform impl. Test cases are updated without adding new one.