refactor(es/transforms/bugfix): visit_mut for edge_default_param #2676
+31
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://discordapp.com/channels/889779439272075314/889785438938726441/906736454737219614
This PR attempts to replace existing fold in
edge_default_parambugfix to visitor. The only reason I choose this module is this looks one of the smallest path I could try to migrate.Change's mostly straightforward, except couple of changes: 1. uses
as_folderto plug migrated visitor to existing logics 2. instead of mappingpropsto reassign, directly replace elements in the vec.