fix(es/transform/compat) fix early return caused by comment above async func in object #2766
+117
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd-object-method-decl
|
|
|
If I'm wrong I'm sorry. Did this PR solved same problem...?🤣 |
|
:oh-no: yes, it looks like aiming same issues while I tried to reuse exising span. Sorry I didn't aware if there was overlapping work. |
kdy1
approved these changes
Nov 17, 2021
|
@kwonoj Oh, you are right. I'll test if it works with this PR reverted. |
|
@kwonoj I'll revert this PR as it's not required. |
kdy1
added a commit
to kdy1/swc
that referenced
this pull request
Nov 17, 2021
This reverts commit ddfc7e6.
OK👍 Thank you for your great work. I'm glad the issue was solved early. |
kdy1
added a commit
that referenced
this pull request
Nov 17, 2021
kdy1
added a commit
to kdy1/swc
that referenced
this pull request
Nov 20, 2021
This reverts commit ddfc7e6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2701
I fixed early return caused by comment above async method in object.
if something wrong, please point it out🙇♂️