-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(es/transforms/compat): Add loose mode to parameters #2911
Conversation
I would need some help @kdy1 var f = function () { ... }
if (true) {
} else {
var _this = this
} Why is this happening? I guess it's because of |
I think (That's why I mentioned creating a new visitor can be better than storing variables) |
var f = function () { ... }
if (true) {
} else {
var _this = this
} for this case, {
var _this = this
} takes the variables, just as those variables are generated by the nested block. |
07b6847
to
9f8cd45
Compare
But |
You can remove |
41add7b
to
ab5d8de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Almost LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I'm bit worried because circular dependency (in dev-dependencies
) may block publising, but let's try.
…ct#2911) swc_ecma_utils: - Make `WrapperState` implement `Clone`. swc_ecma_transforms_compat: - `paramters`: Fix handling of non-loose mode. (Closes swc-project#2800, Closes swc-project#2825)
closes #2825, closes #2800