Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(es/transforms/compat): visit_mut for class_prop:private_field #2966

Merged

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Dec 4, 2021

Continuing #2370.

This PR refactors class_properties. As first part, updates private_field first. PR tries straightforward update as much, not touching existing logics.

@kwonoj kwonoj mentioned this pull request Dec 4, 2021
48 tasks
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kdy1 kdy1 enabled auto-merge (squash) December 4, 2021 11:34
@kdy1 kdy1 added this to the v1.2.118 milestone Dec 4, 2021
@kdy1 kdy1 merged commit 89af8ab into swc-project:main Dec 4, 2021
@kwonoj kwonoj deleted the class-properties-private-field-visit_mut branch December 6, 2021 03:34
nicholasxjy pushed a commit to nicholasxjy/swc that referenced this pull request Dec 18, 2021
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants