Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(actions): setup yarn cache #3015

Merged
merged 1 commit into from
Dec 12, 2021
Merged

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Dec 12, 2021

Description

context: https://discord.com/channels/889779439272075314/889780890098610176/919288953490780181

To workaround the recent CI flaky failure caused by npm pkg installation, I tried pnp. It was mostly working, but some of bundler-related tests expected physical layout of node_modules to resolve its deps.

This PR instead took easy win by setting up dep cache supported by gh actions by default: https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies

If we're lucky global cache may reduce network related failures.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 merged commit 69123dd into swc-project:main Dec 12, 2021
@kdy1 kdy1 added this to the v1.2.120 milestone Dec 12, 2021
@kwonoj kwonoj deleted the yarn-cache-gh-actions branch December 14, 2021 02:34
nicholasxjy pushed a commit to nicholasxjy/swc that referenced this pull request Dec 18, 2021
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants