Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Fix logic for checking arguments #3313

Merged
merged 5 commits into from
Jan 19, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 19, 2022

Description:

swc_ecma_minifier:

  • Don't mark arguments in nested scope as a inline blocker.

@kdy1 kdy1 added this to the v1.2.131 milestone Jan 19, 2022
@kdy1
Copy link
Member Author

kdy1 commented Jan 19, 2022

I verified that it's harmless, by looking at each files.

@kdy1 kdy1 marked this pull request as ready for review January 19, 2022 08:39
@kdy1 kdy1 merged commit 1aa494b into swc-project:main Jan 19, 2022
@kdy1 kdy1 deleted the minifier-arguments branch January 19, 2022 08:39
kdy1 added a commit to kdy1/swc that referenced this pull request Jan 19, 2022
swc_ecma_minifier:
 - Don't mark `arguments` in nested scope as a inline blocker.
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jan 19, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
nevilm-lt pushed a commit to nevilm-lt/next.js that referenced this pull request Apr 22, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

1 participant