Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(swc/wasm): add test cases for minify #5311

Closed
wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Jul 26, 2022

Description:

PR adds simple test cases for the wasm, as we are moving towards to make @swc/wasm as first class citizen. This PR actually fails since newly added test case not able to pass.

BREAKING CHANGE:

Related issue (if exists):

@kwonoj
Copy link
Member Author

kwonoj commented Jul 26, 2022

Interesting thing is it shows different failure than original issue.

   RangeError: Maximum call stack size exceeded

      at swc_ecma_parser::lexer::state::<impl core::iter::traits::iterator::Iterator for swc_ecma_parser::lexer::Lexer<I>>::next::{{closure}}::h33d6f7aea7ae9423 (wasm:/wasm/17487d42:1:9174010)
      at swc_ecma_parser::lexer::state::<impl core::iter::traits::iterator::Iterator for swc_ecma_parser::lexer::Lexer<I>>::next::h07de51b652b79274 (wasm:/wasm/17487d42:1:18208348)
      at swc_ecma_parser::parser::input::Buffer<I>::bump_inner::{{closure}}::h947975deb7378d5c (wasm:/wasm/17487d42:1:67380653)
      at core::option::Option<T>::or_else::hb735b09add21ca84 (wasm:/wasm/17487d42:1:30757873)
      at swc_ecma_parser::parser::input::Buffer<I>::bump_inner::h4372a3cb4430fd0b (wasm:/wasm/17487d42:1:28925442)
      at swc_ecma_parser::parser::input::Buffer<I>::cur::h39d003bfad042fa1 (wasm:/wasm/17487d42:1:52676026)
      at swc_ecma_parser::parser::expr::<impl swc_ecma_parser::parser::Parser<I>>::parse_subscript::h6df51f4270d7254d (wasm:/wasm/17487d42:1:1043749)
      at swc_ecma_parser::parser::expr::<impl swc_ecma_parser::parser::Parser<I>>::parse_subscripts::h79f99ead3e8e0bd6 (wasm:/wasm/17487d42:1:35258862)

@kdy1 kdy1 added this to the Planned milestone Jul 27, 2022
@kdy1
Copy link
Member

kdy1 commented Jul 27, 2022

Oh?
Interesting..

@kwonoj
Copy link
Member Author

kwonoj commented Jul 27, 2022

I don't have good explanations. Fyi, @swc/core works fine.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kwonoj kwonoj force-pushed the test-wasm-minify branch from 3b83eb6 to 0ef6c9e Compare July 30, 2022 18:41
@kwonoj
Copy link
Member Author

kwonoj commented Aug 1, 2022

@kdy1 one more: weirdly, this seems only happening on the debug build. 🤔

@kdy1
Copy link
Member

kdy1 commented Jan 5, 2024

Closing as stale

@kdy1 kdy1 closed this Jan 5, 2024
@kdy1 kdy1 modified the milestones: Planned, v1.3.103 Jan 15, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants