Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cargo): remove redundant packages #5516

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Aug 16, 2022

Description:
We can remove these packages as it is no longer referenced (and update readme's published).

BREAKING CHANGE:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Aug 16, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need swc_ecmascript

@kwonoj
Copy link
Member Author

kwonoj commented Aug 17, 2022

We still need swc_ecmascript

Yes, will revert. Is there way we can announce & instruct migrate into swc_core for the users of swc_ecmascript?

@kdy1
Copy link
Member

kdy1 commented Aug 17, 2022

We need to add more to swc_core before removing it.
See lib.rs of swc_ecmascript

@kdy1
Copy link
Member

kdy1 commented Aug 17, 2022

About migration, we can do same thing like swc_ecma_quote

@kwonoj
Copy link
Member Author

kwonoj commented Aug 17, 2022

Fwiw, swc_core already have ecma_quote support.

@kdy1
Copy link
Member

kdy1 commented Aug 17, 2022

I don't mean swc_core lacks it. swc_ecmascript has much more deps

@kdy1 kdy1 removed this from the Planned milestone May 16, 2023
@kwonoj kwonoj requested review from a team as code owners April 29, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants