Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(html/minifier): remove empty script and style with attributes #6447

Merged
merged 6 commits into from
Nov 17, 2022
Merged

fix(html/minifier): remove empty script and style with attributes #6447

merged 6 commits into from
Nov 17, 2022
+101 −18

Conversation

alexander-akait
Copy link
Contributor

Description:

Remove empty script and style tags with default options

BREAKING CHANGE:

No

Related issue (if exists):

No

kdy1
kdy1 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_html_minifier

@kdy1 kdy1 added this to the Planned milestone Nov 15, 2022
kdy1
kdy1 requested changes Nov 15, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed

@kdy1 kdy1 marked this pull request as draft November 15, 2022 22:57
@alexander-akait
Copy link
Contributor Author

@kdy1 Fixed, just clippy

@alexander-akait alexander-akait marked this pull request as ready for review November 15, 2022 23:35
@kdy1 kdy1 enabled auto-merge (squash) November 15, 2022 23:43
@alexander-akait alexander-akait force-pushed the fix-empty-elements-for-script-and-style branch from fb152a0 to bd64862 Compare November 16, 2022 17:53
@alexander-akait
Copy link
Contributor Author

@kdy1 rebased and ready for review

swc-bot
swc-bot reviewed Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 7441721 into swc-project:main Nov 17, 2022
@alexander-akait alexander-akait deleted the fix-empty-elements-for-script-and-style branch November 17, 2022 01:45
@kdy1 kdy1 modified the milestones: Planned, v1.3.19 Nov 20, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.19
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-akait @kdy1 @swc-bot