Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Handle nullish in fn expr scope #7980

Merged
merged 3 commits into from
Sep 21, 2023
Merged

fix(es/compat): Handle nullish in fn expr scope #7980

merged 3 commits into from
Sep 21, 2023
+61 −1

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari commented Sep 20, 2023 •
edited by kdy1
Loading

@magic-akari magic-akari marked this pull request as ready for review September 20, 2023 15:53
@kdy1 kdy1 added this to the Planned milestone Sep 21, 2023
kdy1
kdy1 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_compat

@kdy1 kdy1 enabled auto-merge (squash) September 21, 2023 05:16
@kdy1 kdy1 merged commit 5050f58 into swc-project:main Sep 21, 2023
127 of 128 checks passed
@Hotell
Copy link

Hotell commented Sep 21, 2023

many thanks for quick fix ! any ETA when new release will land on npm ? cheers

@kdy1 kdy1 modified the milestones: Planned, v1.3.87 Sep 22, 2023
@magic-akari magic-akari deleted the fix/issue-7977 branch September 27, 2023 07:09
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jridgewell jridgewell jridgewell left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.87
Development

Successfully merging this pull request may close these issues.

bug: nullish coalescing with function invokation is not properly compiled
4 participants
@magic-akari @Hotell @jridgewell @kdy1