fix(es/compat): Handle private names from class properties pass #8090

kdy1 · 2023-10-10T07:11:36Z

Description:

Related issue:

kdy1

swc-bump:

swc_ecma_compat_es2020
swc_ecma_compat_es2022

jridgewell · 2023-10-11T01:12:53Z

crates/swc/tests/fixture/issues-7xxx/7561/output/1.js

+class Foo {
+    test() {
+        var _this_y, _this_y1;
+        _this_y === null || _this_y === void 0 ? void 0 : _class_private_field_get._(_this_y1 = this?.y, _x);


This is still broken. What's _this_y isn't assigned, this?.y still remains in the call args.

It was a problem with the target ES version.
I added tests to show the result per the target ES version

crates/swc/tests/fixture/issues-7xxx/7561/es2019/output/1.js

jridgewell

All of the outputs only show the assignment happening in the call arg, after the conditional has already early short-circuited:

_this_y === null || _this_y === void 0 ? void 0 : _class_private_field_get._(_this_y1 = (_this = this) === null || _this === void 0 ? void 0 : _this.y, _x);

The private names transform itself needs to handle optional chaining. We did the same thing in Babel, essentially reimplmementing it in both trasnformers.

jridgewell · 2023-10-17T21:56:30Z

crates/swc_ecma_transforms_compat/tests/optional-chaining/issue-7561/output.js

+    test() {
+        var _this;
+        var _this_y, _this_y1;
+        _this_y === null || _this_y === void 0 ? void 0 : _class_private_field_get(_this_y1 = (_this = this) === null || _this === void 0 ? void 0 : _this.y, _x);


I'm not sure where our miscommunication is coming from, but this is still incorrect.

- _this_y === null || _this_y === void 0 ? void 0 : _class_private_field_get(_this_y1 = (_this = this) === null || _this === void 0 ? void 0 : _this.y, _x); + (_this = this) === null || _this === void 0 ? void 0 : _class_private_field_get(_this.y, _x);

kdy1 · 2023-10-27T23:48:03Z

crates/swc/tests/fixture/issues-7xxx/7561/es2019/output/1.js

+var _x = /*#__PURE__*/ new WeakMap();
+class Foo {
+    test() {
+        var _this, _this_y;


This is not ideal

@jridgewell But let's fix correctness issues first.

kdy1

swc-bump:

swc_ecma_compat_es2020
swc_ecma_compat_es2022

kdy1 · 2023-10-30T02:38:22Z

crates/swc/tests/tsc-references/privateNameFieldCallExpression.1.normal.js

@@ -5,10 +5,9 @@ import { _ as _class_private_field_set } from "@swc/helpers/_/_class_private_fie
 var _fieldFunc = /*#__PURE__*/ new WeakMap(), _fieldFunc2 = /*#__PURE__*/ new WeakMap();
 class A {
    test() {
-        var _class_private_field_get1;
-        var _this_getInstance;
+        var _this, _this1, _ref, _this_getInstance;


Previous output seems wrong

swc-bot

Automated review comment generated by auto-rebase script

kdy1 added this to the Planned milestone Oct 10, 2023

kdy1 requested a review from jridgewell October 10, 2023 07:11

kdy1 self-assigned this Oct 10, 2023

kdy1 marked this pull request as ready for review October 10, 2023 07:11

kodiakhq bot previously approved these changes Oct 10, 2023

View reviewed changes

kdy1 commented Oct 10, 2023

View reviewed changes

jridgewell suggested changes Oct 11, 2023

View reviewed changes

kdy1 dismissed kodiakhq[bot]’s stale review via d9e76a3 October 11, 2023 04:41

kodiakhq bot previously approved these changes Oct 11, 2023

View reviewed changes

kdy1 dismissed kodiakhq[bot]’s stale review via 7e50c23 October 11, 2023 04:41

kodiakhq bot previously approved these changes Oct 11, 2023

View reviewed changes

kdy1 dismissed kodiakhq[bot]’s stale review via 767a245 October 11, 2023 04:51

kodiakhq bot previously approved these changes Oct 11, 2023

View reviewed changes

kdy1 requested a review from jridgewell October 11, 2023 04:52

kdy1 commented Oct 11, 2023

View reviewed changes

crates/swc/tests/fixture/issues-7xxx/7561/es2019/output/1.js Outdated Show resolved Hide resolved

jridgewell suggested changes Oct 11, 2023

View reviewed changes

kdy1 dismissed kodiakhq[bot]’s stale review via d3565b0 October 11, 2023 21:58

kodiakhq bot previously approved these changes Oct 11, 2023

View reviewed changes

kdy1 dismissed kodiakhq[bot]’s stale review via 767a245 October 12, 2023 00:07

kdy1 force-pushed the issue-7561 branch from d3565b0 to 767a245 Compare October 12, 2023 00:07

kodiakhq bot previously approved these changes Oct 12, 2023

View reviewed changes

jridgewell suggested changes Oct 17, 2023

View reviewed changes

kdy1 dismissed kodiakhq[bot]’s stale review via 43fe017 October 19, 2023 17:22

kdy1 force-pushed the issue-7561 branch from 767a245 to 43fe017 Compare October 19, 2023 17:22

kodiakhq bot previously approved these changes Oct 19, 2023

View reviewed changes

kdy1 marked this pull request as draft October 19, 2023 18:59

kdy1 force-pushed the issue-7561 branch from 43fe017 to 4f2e1f9 Compare October 27, 2023 16:26

kdy1 dismissed kodiakhq[bot]’s stale review via f93db5d October 27, 2023 17:12

kdy1 commented Oct 27, 2023

View reviewed changes

kdy1 commented Oct 28, 2023

View reviewed changes

kdy1 added 12 commits October 30, 2023 11:35

Fix more

df04e7f

Fix more

efecbd3

Update test refs

419cf09

Update test refs

85da7f5

Update test refs

3013d85

Add a test

e198f2d

Change order

7c2071f

this to opt chain

a05a045

Update test refs

f433157

Update test refs

76c85cb

is_private_access

721d78a

Update test refs

d8cbdb1

kdy1 force-pushed the issue-7561 branch from eaf463f to d8cbdb1 Compare October 30, 2023 02:36

kdy1 marked this pull request as ready for review October 30, 2023 02:37

kodiakhq bot previously approved these changes Oct 30, 2023

View reviewed changes

kdy1 commented Oct 30, 2023

View reviewed changes

jridgewell previously approved these changes Nov 2, 2023

View reviewed changes

Merge branch 'main' into issue-7561

dcc3aa9

kdy1 dismissed stale reviews from jridgewell and kodiakhq[bot] via dcc3aa9 November 2, 2023 21:39

kdy1 enabled auto-merge (squash) November 2, 2023 21:39

kodiakhq bot approved these changes Nov 2, 2023

View reviewed changes

Merge branch 'main' into issue-7561

fb3ddbd

swc-bot reviewed Nov 2, 2023

View reviewed changes

kdy1 merged commit 83a5a0c into swc-project:main Nov 2, 2023
278 checks passed

kdy1 deleted the issue-7561 branch November 2, 2023 22:18

fspoettel mentioned this pull request Nov 3, 2023

CancelablePromise fails to resolve with Next.js 13 ferdikoomen/openapi-typescript-codegen#1626

Open

kdy1 modified the milestones: Planned, v1.3.96 Nov 3, 2023

swc-project locked as resolved and limited conversation to collaborators Dec 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(es/compat): Handle private names from class properties pass #8090

fix(es/compat): Handle private names from class properties pass #8090

kdy1 commented Oct 10, 2023 •

edited

Loading

kdy1 left a comment •

edited

Loading

jridgewell Oct 11, 2023

kdy1 Oct 11, 2023

jridgewell left a comment

jridgewell Oct 17, 2023

kdy1 Oct 27, 2023

kdy1 Oct 29, 2023

kdy1 left a comment

kdy1 Oct 30, 2023

swc-bot left a comment

fix(es/compat): Handle private names from class properties pass #8090

fix(es/compat): Handle private names from class properties pass #8090

Conversation

kdy1 commented Oct 10, 2023 • edited Loading

kdy1 left a comment • edited Loading

Choose a reason for hiding this comment

jridgewell Oct 11, 2023

Choose a reason for hiding this comment

kdy1 Oct 11, 2023

Choose a reason for hiding this comment

jridgewell left a comment

Choose a reason for hiding this comment

jridgewell Oct 17, 2023

Choose a reason for hiding this comment

kdy1 Oct 27, 2023

Choose a reason for hiding this comment

kdy1 Oct 29, 2023

Choose a reason for hiding this comment

kdy1 left a comment

Choose a reason for hiding this comment

kdy1 Oct 30, 2023

Choose a reason for hiding this comment

swc-bot left a comment

Choose a reason for hiding this comment

kdy1 commented Oct 10, 2023 •

edited

Loading

kdy1 left a comment •

edited

Loading