fix(es/minifier): Add WeakRef as a safe global reference #8458
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I was trying to remove references to Weak Ref from minified code and despite the expression not being used, it was still included.
E.g.
with
outputs
but when I use something on this list e.g. parseFloat, it gets cleaned up and outputs empty string.
btw - I tried different options for pure_getters that I assumed would allow me to say WeakRef as a getter was pure, but it had no effect.
WeakRef getter is as safe to remove as the other items on this list and has no effect in accessing it.