Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): Remove < and > from Display impl of FileName::Custom #8530

Merged
merged 3 commits into from
Jan 21, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 20, 2024

Description:

It causes some problems for turbopack.

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Jan 20, 2024
@kdy1 kdy1 self-assigned this Jan 20, 2024
@kdy1 kdy1 marked this pull request as ready for review January 21, 2024 00:51
@kdy1 kdy1 requested a review from a team as a code owner January 21, 2024 00:51
@kdy1 kdy1 enabled auto-merge (squash) January 21, 2024 00:51
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_common

@kdy1 kdy1 merged commit 014a6cd into swc-project:main Jan 21, 2024
141 of 143 checks passed
@kdy1 kdy1 deleted the filename-custom branch January 21, 2024 02:32
@kdy1 kdy1 modified the milestones: Planned, v1.3.105 Jan 21, 2024
kdy1 added a commit to vercel/next.js that referenced this pull request Jan 27, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants