perf(es/lints): Avoid needless allocations in no-dupe-args
#9041
+807
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
commented
Jun 12, 2024
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
sokra
reviewed
Jun 12, 2024
sokra
reviewed
Jun 12, 2024
sokra
reviewed
Jun 12, 2024
Comment on lines
+15
to
+16
| /// This has time complexity of O(n^2), but it's fine as the number of paramters | ||
| /// is usually small. |
There was a problem hiding this comment.
This probably holds true for 99.9%, but maybe we can add another implementation that is used for n > 100 based on a hashmap.
swc-bot
reviewed
Jun 12, 2024
sokra
reviewed
Jun 12, 2024
sokra
reviewed
Jun 12, 2024
| .struct_span_err( | ||
| id2.span, | ||
| &format!( | ||
| "the name `{}` is bound more than once in this parameter list", |
There was a problem hiding this comment.
If a binding is defined 3 times this error will be reported multiple times. That was already the case with the old implementation.
There was a problem hiding this comment.
That's handled by done. Actually I added done just to match the original behavior.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I introduced a zero-allocation variant for
swc_ecma_utils::DestructuringFinderthat does not allocate anything.Related issue (if exists):