Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/decorator): Add support for private access expressions in legacy decorators #9535

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

magic-akari
Copy link
Member

Copy link

changeset-bot bot commented Sep 5, 2024

🦋 Changeset detected

Latest commit: a1606d1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #9535 will degrade performances by 5.43%

Comparing magic-akari:fix/issue-9429 (a1606d1) with main (c43dbad)

Summary

❌ 2 regressions
✅ 176 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main magic-akari:fix/issue-9429 Change
es/full/bugs-1 533.4 µs 564.1 µs -5.43%
es/full/codegen/es2015 275.1 µs 290.6 µs -5.32%

@magic-akari
Copy link
Member Author

I have no clue about this performance regression.

@magic-akari magic-akari marked this pull request as ready for review September 6, 2024 06:01
@magic-akari magic-akari requested review from a team as code owners September 6, 2024 06:01
@kdy1 kdy1 merged commit 62ed065 into swc-project:main Sep 6, 2024
155 checks passed
@kdy1 kdy1 added this to the Planned milestone Sep 6, 2024
@magic-akari magic-akari deleted the fix/issue-9429 branch September 6, 2024 09:02
@kdy1 kdy1 modified the milestones: Planned, v1.7.24 Sep 8, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Cannot implement decorator as a private method
2 participants