refactor(es/typescript): Simplifying enum and namespace transforms #9558
+3,049
−3,337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fb21f56 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
magic-akari
changed the title
CodSpeed Performance ReportMerging #9558 will improve performances by 3.44%Comparing Summary
Benchmarks breakdown
|
magic-akari
force-pushed
the
refactor/typescript
branch
from
b6a4e5b to
6b11f50
Compare
magic-akari
commented
Sep 30, 2024
|
|
||
| let mut decl_id_record = AHashSet::<Id>::default(); | ||
| fn visit_mut_assign_expr(&mut self, n: &mut AssignExpr) { | ||
| let is_lhs = mem::replace(&mut self.is_lhs, true); |
There was a problem hiding this comment.
It will be helpful if we have semantic analysis.
I need help solving a stack overflow issue. @kdy1 |
kdy1
reviewed
Oct 1, 2024
| VarDeclKind::Let | ||
| }; | ||
|
|
||
| let init_arg = 'init_arg: { |
There was a problem hiding this comment.
This feature has been introduced for a long time, and I expect it to work on MSRV.
https://rust-lang.github.io/rfcs/2046-label-break-value.html
|
I'm investigating stack overflow issue. |
magic-akari
force-pushed
the
refactor/typescript
branch
from
3a20d4c to
6ce5bdb
Compare
magic-akari
force-pushed
the
refactor/typescript
branch
from
53b9a36 to
8671fbb
Compare
kdy1
approved these changes
Oct 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
/*#__PURE__*/for ts enum #9385