Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/proposal): Use tsc version of explicit resource management #9585

Merged
merged 28 commits into from
Oct 17, 2024
Merged

fix(es/proposal): Use tsc version of explicit resource management #9585

merged 28 commits into from
Oct 17, 2024
+12,894 −6,704

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Sep 25, 2024

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Sep 25, 2024
@kdy1 kdy1 self-assigned this Sep 25, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: cc5c52d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 mentioned this pull request Sep 25, 2024
Merged
kdy1 added a commit that referenced this pull request Sep 25, 2024
@kdy1
chore(es): Add helpers (#9586)
b94a0e1 
**Description:**

This is a part of #9585. I extracted this as a separate PR to make WIP small.
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 25, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9585 will improve performances by 3.46%

Comparing kdy1:issue-9576 (cc5c52d) with main (39e0f9c)

Summary

⚡ 2 improvements
✅ 192 untouched benchmarks

Benchmarks breakdown

Benchmark main kdy1:issue-9576 Change
⚡ es/full/base/fixer 122.6 µs 118.9 µs +3.06%
⚡ es/full/parser 1.5 ms 1.5 ms +3.46%

@kdy1
Copy link
Member Author

kdy1 commented Sep 27, 2024

It seems like I should use the test suite from TS. I'll continue working on this next Monday.

@kdy1 kdy1 changed the title fix(es/proposal): Call asyncDispose correctly fix(es/proposal): Use tsc version of explicit resource management Oct 17, 2024
@kdy1 kdy1 marked this pull request as ready for review October 17, 2024 04:19
@kdy1 kdy1 requested review from a team as code owners October 17, 2024 04:19
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 17, 2024
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 17, 2024
View reviewed changes
@socket-security Socket Security
Copy link

socket-security bot commented Oct 17, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/nanoid@4.0.2 None 0 15.3 kB ai

🚮 Removed packages: npm/string.prototype.trimstart@1.0.6

View full report↗︎

kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 17, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) October 17, 2024 05:32
@kdy1 kdy1 merged commit f735108 into swc-project:main Oct 17, 2024
153 of 154 checks passed
@kdy1 kdy1 deleted the issue-9576 branch October 17, 2024 05:51
@kdy1 kdy1 modified the milestones: Planned, v1.7.37 Oct 21, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.7.37
Development

Successfully merging this pull request may close these issues.

Bug: dispose hooks not called with using keyword
1 participant
@kdy1