Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct option types of wasm-typescript functions #9662

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

bennypowers
Copy link
Contributor

Description:

The types for the wasm-typescript functions are incorrect due to a typo.

Without this fix:

Property 'TransformConfig' is missing in type '{ module: true; filename: any; sourceMap:   • 
 true; mode: "transform"; transform: { verbatimModuleSyntax: boolean; nativeClassProperties:       
 boolean; importNotUsedAsValues: string; importExportAssignConfig: string; }; }' but required in   
 type 'Options'. [2345]  

without this fix:

```
Property 'TransformConfig' is missing in type '{ module: true; filename: any; sourceMap:   • 
 true; mode: "transform"; transform: { verbatimModuleSyntax: boolean; nativeClassProperties:       
 boolean; importNotUsedAsValues: string; importExportAssignConfig: string; }; }' but required in   
 type 'Options'. [2345]  
```
@bennypowers bennypowers requested a review from a team as a code owner October 20, 2024 09:10
Copy link

changeset-bot bot commented Oct 20, 2024

⚠️ No Changeset found

Latest commit: a59e354

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2024

CLA assistant check)
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kdy1 kdy1 added this to the Planned milestone Oct 20, 2024
@kdy1 kdy1 enabled auto-merge (squash) October 20, 2024 09:40
@kdy1 kdy1 merged commit 4cbe33c into swc-project:main Oct 20, 2024
153 of 154 checks passed
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #9662 will degrade performances by 4.71%

Comparing bennypowers:patch-1 (a59e354) with main (32116a0)

Summary

❌ 1 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bennypowers:patch-1 Change
es/full/bugs-1 524.8 µs 550.8 µs -4.71%

@kdy1 kdy1 modified the milestones: Planned, v1.7.37 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants