Switching to kramdown #183
Conversation
Redcarpet doesn't handle Markdown in HTML blocks (like div's). This PR switches to Kramdown, which *does* handle md-in-html. However, Kramdown translates single and double quotes into curly quotes by default, which confuses downstream tools, so we have to turn that off. While we're there, we also tell it to output character entities as character entities.
|
On Sat, Nov 30, 2013 at 07:13:57AM -0800, Greg Wilson wrote:
Commit messages should be a a one-line summary followed by a blank $ git log --oneline origin/pr/183 It also looky like you're pulling in more than just the cramdown
Here's the graphical log: $ git log --graph --topo-order --oneline --decorate origin/pr/183
Was 485706c intentional? Perhaps this PR should just be 9051480 on |
|
On Sat, Nov 30, 2013 at 09:18:54AM -0800, W. Trevor King wrote:
While it's the top commit in your PR branch, it should be easy to fix $ git commit --amend After you fix the commit message, you can force-push the fixed commit |
|
@gvwilson - The consequences of this change will be that we can no longer rely on I think everybody knows that I was never a strong proponent of managing our development from The project seems active, I think it's good for us to not rely too heavily on GitHub, and I'd like to continue to separate our document authoring/page generation from our version control repository. Strong +1 from me. |
|
Seethe gh-pages branch of https://github.com/gvwilson/trying-kramdown |
|
😮 Awesome, that's new. It looks like this is solving your problem, it's a On Sat, Nov 30, 2013 at 3:52 PM, Greg Wilson notifications@github.comwrote:
|
|
Anybody else have an opinion on this, or would perhaps like more time to review this before it's merged in? |
|
Can someone with a generic Jekyll install please try this branch on their machine and confirm that using kramdown works out of the box (as well as on GitHub)? cc @drio @r-gaia-cs |
|
@gvwilson It work out of the box for me. $ ruby -v
ruby 2.0.0p353 (2013-11-22 revision 43784) [x86_64-linux]
$ gem -v
2.0.14
$ kramdown -v
1.2.0Before merge can you update the $ grep -n redcarpet README.md
208: gem install redcarpet
219:gem install redcarpet |
|
Works fine for me also: drio@drds-air:~/dev/swc/bc *(gh-pages)*$ ruby -v
ruby 2.0.0p353 (2013-11-22 revision 43784) [x86_64-darwin11.4.2]
drio@drds-air:~/dev/swc/bc *(gh-pages)*$ gem -v
2.0.14
drio@drds-air:~/dev/swc/bc *(gh-pages)*$ kramdown -v
1.0.2 |
|
@drio were you able to build the site as well? (I'm worried that just having the tools might miss something...) |
|
Yes: |
Jekyll uses Redcarpet by default for translating Markdown to HTML, but Redcarpet doesn't handle Markdown in HTML blocks (like div's). This PR switches to Kramdown, which does handle md-in-html. However, Kramdown translates single and double quotes into curly quotes by default, which confuses downstream tools, so we have to turn that off. While we're there, we also tell it to output character entities as character entities. It also inserts the attribute:
in certain