Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add this (or something like it) to the lesson? #188

Closed
gvwilson opened this issue Nov 15, 2015 · 3 comments
Closed

Add this (or something like it) to the lesson? #188

gvwilson opened this issue Nov 15, 2015 · 3 comments

Comments

@gvwilson
Copy link
Contributor

@jttkim
Copy link

jttkim commented Nov 16, 2015

While this surely has put a smile on my face I'm not so sure these flowcharts are exactly novice materials, for two reasons. (1) Novices can have a tenuous grasp on reading flowcharts and they may be put off by them, and (2) the implied background situation (with multiple repos, including one at github, and others depending on that) is (way too) advanced, it will take novices a long way to understand that scenario.

@wking
Copy link
Contributor

wking commented Nov 16, 2015

On Sun, Nov 15, 2015 at 05:57:20PM -0800, Jan T. Kim wrote:

… the implied background situation (with multiple repos, including
one at github, and others depending on that) is (way too) advanced,
it will take novices a long way to understand that scenario.

+1. There's a big gap between “I pulled our collaborative master, and
now have to resolve a merge conflict” (which is where git-novice will
take you) and “Given a queue full of pull requests, the easiest ones
to grok will be reviewed first, will get more feedback, and as a
result, will be merged first” [1](which is what Hileman is helping
you with). I think there's certainly room for a lesson around
branching, pull-requests, and collaborative workflows. Talking about
focused branches with pretty, atomic commits would be a great fit
there, but that's not this repository.

@daisieh
Copy link
Contributor

daisieh commented Nov 17, 2015

Definitely too advanced for git-novice, IMO.

statkclee pushed a commit to statkclee/git-novice that referenced this issue Dec 20, 2015
rgaiacs added a commit to rgaiacs/swc-git-novice that referenced this issue Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants