-
-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reference to gitignore #1036
base: main
Are you sure you want to change the base?
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/git-novice/compare/md-outputs..md-outputs-PR-1036 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-11-18 00:19:43 +0000 |
Looks good to me, but I'm confused on why Git is marking every line of the file as a change. Is there a way to fix it? If it's about line endings, I'm worried this might mess up the markdown parser (although it's unlikely). |
I was using RStudio to make the changes so I could build the pages and test before pushing. It was saving the changes with CRLF. I changed the Line ending conversion setting under Tools | Global Options | Code | Saving to LR.
…________________________________
From: Martino Sorbaro ***@***.***>
Sent: Tuesday, November 5, 2024 01:45
To: swcarpentry/git-novice ***@***.***>
Cc: Erin Graham ***@***.***>; Author ***@***.***>
Subject: Re: [swcarpentry/git-novice] Remove reference to gitignore (PR #1036)
This message was sent from someone external to JCU. Please do not click links or open attachments unless you recognise the source of this email and know the content is safe.
Looks good to me, but I'm confused on why Git is marking every line of the file as a change. Is there a way to fix it? If it's about line endings, I'm worried this might mess up the markdown parser (although it's unlikely).
—
Reply to this email directly, view it on GitHub<#1036 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA5FFRNP2RM6OKTQLYONT4LZ66JCHAVCNFSM6AAAAABRCLWYPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJVGA2TOOJWHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I noticed it's possible to get github to show the actual changes by clicking on the gear and selecting 'hide whitespace'. Should we keep the part that says 'these files are not special and their sole purpose is to populate a directory so that Git adds it to the repository' perhaps? |
I agree with issue #687 contributors that the reference to .gitignore in this callout comes out of nowhere so I'm removing it for now.
However, this callout needs to be revisited to consider having it in this location in the lesson and the fact that it makes changes that might be missed. (Instructors pressed for time will selectively skip callouts and this may have downstream effects.)
Note that there are some unintended changes due to line endings or whitespace adjustments which I will aim to fix in the PR :-(