Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few corrections to episode 4 #1057

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

fiveop
Copy link
Contributor

@fiveop fiveop commented Dec 9, 2024

Commits:

  • No. 1: I think the change makes the sentence easier to read.
  • No. 2: Remove accidental word repetition
  • No. 3: Remove contraction from prose (I noticed that his was done consistently throughout the document; feel free to remove this commit from the PR, if that was intentional.)

Copy link

github-actions bot commented Dec 9, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/git-novice/compare/md-outputs..md-outputs-PR-1057

The following changes were observed in the rendered markdown documents:

 04-changes.md | 5 ++---
 md5sum.txt    | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-12-11 10:15:45 +0000

@fiveop fiveop changed the title Rephrase sentence A few corrections Dec 9, 2024
github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
@fiveop fiveop changed the title A few corrections A few corrections to episode 4 Dec 9, 2024
@fiveop fiveop force-pushed the phrase_structure_of branch from ef95945 to e806f69 Compare December 9, 2024 10:44
github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
@martinosorb
Copy link
Contributor

Hi @fiveop, thanks for this. The first two changes are great and should be merged.
While I agree that there is no consistency in using or not using contractions in this whole lesson, we shouldn't change this in a single episode and leave the others the same. I would not want you to go through every file in the whole lesson, so I would suggest we leave it as it is from this point of view.

@fiveop fiveop force-pushed the phrase_structure_of branch from e806f69 to e173d96 Compare December 11, 2024 10:14
@fiveop
Copy link
Contributor Author

fiveop commented Dec 11, 2024

I removed the third commit.

github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
@martinosorb
Copy link
Contributor

Thank you!

@martinosorb martinosorb merged commit 9bc5ac5 into swcarpentry:main Dec 11, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
Auto-generated via `{sandpaper}`
Source  : 9bc5ac5
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2024-12-11 17:44:11 +0000
Message : Merge pull request #1057 from fiveop/phrase_structure_of

A few corrections to episode 4
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
Auto-generated via `{sandpaper}`
Source  : 4830216
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-12-11 17:44:56 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 9bc5ac5
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2024-12-11 17:44:11 +0000
Message : Merge pull request #1057 from fiveop/phrase_structure_of

A few corrections to episode 4
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
Auto-generated via `{sandpaper}`
Source  : 4830216
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-12-11 17:44:56 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 9bc5ac5
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2024-12-11 17:44:11 +0000
Message : Merge pull request #1057 from fiveop/phrase_structure_of

A few corrections to episode 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants