Issue #507 - Episode 14 - Added guidance for RStudio users when Git.exe path not pre-filled #531
Conversation
This is a particular problem with Windows, as the Git executable path does not seem to self populate on Windows 10.
|
This looks like a really good addition. |
|
For transparency: I requested review from some of the maintainers from the r lessons that regularly use git with RStudio to weigh in on this PR. This PR looks great to me @richmccue . Would you mind updating your PR with @murraycadzow 's suggestion and then I'll merge it into the lesson. The clarifying work you've done here is really helpful and I think it will be appreciated by all of the learners interested in git+RStudio. |
munkm
added
status:in progress
|
Looks good to me! |
There was a problem hiding this comment.
I'm happy to merge if the slight clarification mentioned in the discussion is incorporated. Alternatively we can open an issue for these changes if @richmccue isn't able to update the PR and merge as is. Let us know what you think richmccue!
|
Due to carpentries/workshop-template#574 I have a fresh macOS available that hasn't seen RStudio now. My approving review was from before that. Shall I test the instructions? |
|
Sure that sounds good @katrinleinweber. |
I've updated the language around making sure that git is installed as suggested by @murraycadozow (Issue swcarpentry#507) to take into account the face that Git may be installed as part of the OS
|
I've updated the language around making sure that Git is installed as suggested by @murraycadozow (Issue #507) to take into account the fact that Git may be installed as part of the OS. |
|
Awesome! Thank you so much @richmccue. I'm happy to merge, but I'd like to wait until @katrinleinweber verifies that they can follow the instructions on their machine to double check everything works. 🙂 |
| > Copy the path to the git executable (e.g. On one Windows computer which had | ||
| > GitHub Desktop installed on it, the path was: | ||
| > | ||
| > If there is no version of Git on your computer, please either install [Git](https://git-scm.com/downloads/) |
There was a problem hiding this comment.
How about referring to https://carpentries.github.io/workshop-template/#git here so that we do not need to maintain extra instructions here at all? https://swcarpentry.github.io/git-novice/setup.html is already doing that as well.
There was a problem hiding this comment.
Alternatively if the directions are clear we can merge this PR and open an issue for another new contributor to update this URL. richmccue has already spent a lot of time on this PR.
There was a problem hiding this comment.
Which can not be recovered unfortunately, and therefore should not be part of the decision when what gets merged ;-)
I don't mean this harshly at all; Please don't get me wrong! I'm grateful to @richmccue for alerting us to the problem and for providing a fix :-) Just pointing out that previous maintainers choose to refer to the setup info that's maintained centrally.
Will test this on the weekend and report back.
There was a problem hiding this comment.
Thank you for the helpful wikipedia link.
I agree that this link should point to the same instructions as the setup to be consistent with the rest of the lesson. I do not think that that merging this PR should be blocked by this link being inconsistent.
|
Reading from the top again, I can't help after all. This "seems to be more of a problem on Windows computers." Presumably, "learner might have git installed as part of the OS" prompted me to to comment upon reading it initially, sorry. |
|
Thank you so much for all of your hard work @richmccue! |
kekoziar
removed
status:changes requested
Issue #507 - Episode 14 - Added guidance for RStudio users when Git.exe path not pre-filled
In response to Issue #507 I added some text to Episode 14 to give some direction to users when the Git executable path in RStudio is not pre-filled for them. This seems to be more of a problem on Windows computers.