Fix Windows CRLF configuration recommendation to auto. #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
kekoziar
approved these changes
Sep 11, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 11, 2023
Auto-generated via {sandpaper}
Source : 4988c45
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2023-09-11 19:46:27 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 245a640
Branch : main
Author : K.E. Koziar <katherine.koziar@ucr.edu>
Time : 2023-09-11 19:45:00 +0000
Message : Merge pull request #969 from thompsonmj/main
Fix Windows CRLF configuration recommendation to auto.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
Auto-generated via {sandpaper}
Source : 4988c45
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2023-09-11 19:46:27 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 245a640
Branch : main
Author : K.E. Koziar <katherine.koziar@ucr.edu>
Time : 2023-09-11 19:45:00 +0000
Message : Merge pull request #969 from thompsonmj/main
Fix Windows CRLF configuration recommendation to auto.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
Auto-generated via {sandpaper}
Source : 4988c45
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2023-09-11 19:46:27 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 245a640
Branch : main
Author : K.E. Koziar <katherine.koziar@ucr.edu>
Time : 2023-09-11 19:45:00 +0000
Message : Merge pull request #969 from thompsonmj/main
Fix Windows CRLF configuration recommendation to auto.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Addresses #966
Please briefly summarize the changes made in the pull request, and the reason(s) for making these changes.
On Windows machines it is recommended in git documentation and GitHub docs to make sure line endings are suitable for projects where collaborators work between Windows and Unix-based systems.
If any relevant discussions have taken place elsewhere, please provide links to these.
A
.gitattributesaddition to make sure this is handled at the repository level rather than the user level (fickle) may be a good alternative or addition to this change:https://www.edwardthomson.com/blog/git_for_windows_line_endings.html
For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.
Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.