Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note about ssh keys #971

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

lexnederbragt
Copy link
Contributor

Unless I am mistaken, using ssh keys is now a requirement, which makes this note outdated.

Using ssh keys is now a requirement so this note is outdated.
@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/git-novice/compare/md-outputs..md-outputs-PR-971

The following changes were observed in the rendered markdown documents:

 instructor-notes.md | 5 -----
 md5sum.txt          | 2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-09-15 11:17:30 +0000

github-actions bot pushed a commit that referenced this pull request Sep 15, 2023
Copy link
Contributor

@kekoziar kekoziar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This artifact was missed during the original adoption of ssh keys into the lesson.

@kekoziar kekoziar merged commit e2047da into swcarpentry:main Sep 18, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 18, 2023
Auto-generated via {sandpaper}
Source  : e2047da
Branch  : main
Author  : K.E. Koziar <katherine.koziar@ucr.edu>
Time    : 2023-09-18 18:47:27 +0000
Message : Merge pull request #971 from lexnederbragt/patch-1

Remove note about ssh keys
github-actions bot pushed a commit that referenced this pull request Sep 18, 2023
Auto-generated via {sandpaper}
Source  : 8ac0a2b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-09-18 18:48:56 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e2047da
Branch  : main
Author  : K.E. Koziar <katherine.koziar@ucr.edu>
Time    : 2023-09-18 18:47:27 +0000
Message : Merge pull request #971 from lexnederbragt/patch-1

Remove note about ssh keys
github-actions bot pushed a commit that referenced this pull request Sep 19, 2023
Auto-generated via {sandpaper}
Source  : 8ac0a2b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-09-18 18:48:56 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e2047da
Branch  : main
Author  : K.E. Koziar <katherine.koziar@ucr.edu>
Time    : 2023-09-18 18:47:27 +0000
Message : Merge pull request #971 from lexnederbragt/patch-1

Remove note about ssh keys
github-actions bot pushed a commit that referenced this pull request Sep 26, 2023
Auto-generated via {sandpaper}
Source  : 8ac0a2b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-09-18 18:48:56 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e2047da
Branch  : main
Author  : K.E. Koziar <katherine.koziar@ucr.edu>
Time    : 2023-09-18 18:47:27 +0000
Message : Merge pull request #971 from lexnederbragt/patch-1

Remove note about ssh keys
github-actions bot pushed a commit to UCSBCarpentry/git-novice that referenced this pull request Sep 26, 2023
Auto-generated via {sandpaper}
Source  : e2047da
Branch  : main
Author  : K.E. Koziar <katherine.koziar@ucr.edu>
Time    : 2023-09-18 18:47:27 +0000
Message : Merge pull request swcarpentry#971 from lexnederbragt/patch-1

Remove note about ssh keys
github-actions bot pushed a commit to UCSBCarpentry/git-novice that referenced this pull request Sep 26, 2023
Auto-generated via {sandpaper}
Source  : 1355155
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-09-26 01:05:01 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e2047da
Branch  : main
Author  : K.E. Koziar <katherine.koziar@ucr.edu>
Time    : 2023-09-18 18:47:27 +0000
Message : Merge pull request swcarpentry#971 from lexnederbragt/patch-1

Remove note about ssh keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants