Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further warnings in rm exercise #992

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

martinosorb
Copy link
Contributor

Fixes #965, additionally removing a 'just' and clarifying we don't want to remove the whole subdirectory.

Copy link

github-actions bot commented Jul 2, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/git-novice/compare/md-outputs..md-outputs-PR-992

The following changes were observed in the rendered markdown documents:

 03-create.md | 7 ++++---
 md5sum.txt   | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-07-02 15:34:41 +0000

Copy link
Contributor

@erinmgraham erinmgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Challenge now notes rm is irreversible.

@erinmgraham erinmgraham merged commit 8cb8e6c into swcarpentry:main Jul 3, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 3, 2024
Auto-generated via {sandpaper}
Source  : 8cb8e6c
Branch  : main
Author  : erinmgraham <erin.graham@jcu.edu.au>
Time    : 2024-07-03 08:17:26 +0000
Message : Merge pull request #992 from martinosorb/martinosorb-patch-1

Further warnings in rm exercise
github-actions bot pushed a commit that referenced this pull request Jul 3, 2024
Auto-generated via {sandpaper}
Source  : e263f09
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-07-03 08:19:29 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 8cb8e6c
Branch  : main
Author  : erinmgraham <erin.graham@jcu.edu.au>
Time    : 2024-07-03 08:17:26 +0000
Message : Merge pull request #992 from martinosorb/martinosorb-patch-1

Further warnings in rm exercise
github-actions bot pushed a commit that referenced this pull request Jul 3, 2024
Auto-generated via {sandpaper}
Source  : e263f09
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-07-03 08:19:29 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 8cb8e6c
Branch  : main
Author  : erinmgraham <erin.graham@jcu.edu.au>
Time    : 2024-07-03 08:17:26 +0000
Message : Merge pull request #992 from martinosorb/martinosorb-patch-1

Further warnings in rm exercise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add note about how rm from command line is irrecoverable
2 participants