Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "second big question" #997

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Fix "second big question" #997

merged 1 commit into from
Jul 16, 2024

Conversation

martinosorb
Copy link
Contributor

Fixes #946.

Copy link

github-actions bot commented Jul 2, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/git-novice/compare/md-outputs..md-outputs-PR-997

The following changes were observed in the rendered markdown documents:

 13-hosting.md | 3 ++-
 md5sum.txt    | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-07-02 17:26:30 +0000

github-actions bot pushed a commit that referenced this pull request Jul 2, 2024
Copy link
Contributor

@erinmgraham erinmgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix refers to first question directly

@erinmgraham erinmgraham merged commit fe908db into main Jul 16, 2024
3 checks passed
@erinmgraham erinmgraham deleted the martinosorb-patch-5 branch July 16, 2024 04:27
github-actions bot pushed a commit that referenced this pull request Jul 16, 2024
Auto-generated via {sandpaper}
Source  : fe908db
Branch  : main
Author  : erinmgraham <erin.graham@jcu.edu.au>
Time    : 2024-07-16 04:27:00 +0000
Message : Merge pull request #997 from swcarpentry/martinosorb-patch-5

Fix "second big question"
github-actions bot pushed a commit that referenced this pull request Jul 16, 2024
Auto-generated via {sandpaper}
Source  : b7911a9
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-07-16 04:27:53 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : fe908db
Branch  : main
Author  : erinmgraham <erin.graham@jcu.edu.au>
Time    : 2024-07-16 04:27:00 +0000
Message : Merge pull request #997 from swcarpentry/martinosorb-patch-5

Fix "second big question"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A second point is introduced without a first point
2 participants