Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify issues links in CONTRIBUTING.md #362

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Clarify issues links in CONTRIBUTING.md #362

merged 4 commits into from
Aug 2, 2023

Conversation

JCSzamosi
Copy link
Contributor

This pull request is being submitted to all repos that have been converted to Workbench, so that they reflect a recent update in the Workbench template. The change is probably appropriate for your repository, but you may disagree. I encourage you to look at a description of the problem it fixes found in this comment of this issue.

You will still need to replace example.com/FIXME in the [repo] and [repo-issues] link targets.

@github-actions
Copy link

github-actions bot commented Jun 12, 2023 •
edited
Loading

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

henrykironde
henrykironde reviewed Jun 23, 2023
View reviewed changes
Copy link
Contributor

@henrykironde henrykironde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JCSzamosi, made some comments, let me know what you think.

CONTRIBUTING.md Outdated
@@ -102,6 +103,7 @@ media, slack, newsletters, and email lists. You can also [reach us by
email][contact].

[repo]: https://example.com/FIXME
[repo-issues]: https://example.com/FIXME/issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JCSzamosi should we fix the links to point to the repo and repo-issues rather than https://example.com/FIXME?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henrykironde yep, that's the idea! You can do it as a commit to this PR or merge the PR and then open a new one for that change, whatever you prefer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the suggested change you can add as a commit to this PR

Suggested change
[repo-issues]: https://example.com/FIXME/issues
[repo-issues]: https://github.com/swcarpentry/sql-novice-survey/issues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @zkamvar! I can't figure out how to create suggestions in github PRs, so I appreciate it!

github-actions bot pushed a commit that referenced this pull request Jun 26, 2023
@actions-user
differences for PR #362
97697ab
@henrykironde
Copy link
Contributor

I do not have merge permissions at the moment.

@JCSzamosi
Copy link
Contributor Author

@henrykironde check out the instructions in the second comment in #358 to restore your merge permissions

@henrykironde henrykironde mentioned this pull request Aug 2, 2023
Merged
@henrykironde henrykironde merged commit 74b5f59 into swcarpentry:main Aug 2, 2023
@henrykironde
Copy link
Contributor

Thanks @JCSzamosi for the contribution.

github-actions bot pushed a commit that referenced this pull request Aug 2, 2023
@actions-user
markdown source builds
5a06d96 
Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Aug 2, 2023
@actions-user
site deploy
18039ba 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Aug 8, 2023
@actions-user
site deploy
e5024c2 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Aug 15, 2023
@actions-user
site deploy
6595626 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Aug 22, 2023
@actions-user
site deploy
984cb95 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Aug 29, 2023
@actions-user
site deploy
2061c38 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Sep 5, 2023
@actions-user
site deploy
433b67c 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
@actions-user
site deploy
06d6f4a 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Sep 19, 2023
@actions-user
site deploy
480bfe0 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Sep 26, 2023
@actions-user
site deploy
67022bc 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Oct 3, 2023
@actions-user
site deploy
d0ca7db 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Oct 10, 2023
@actions-user
site deploy
4bea1c1 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Oct 10, 2023
@actions-user
site deploy
56de55c 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Oct 10, 2023
@actions-user
site deploy
e829a55 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
@actions-user
site deploy
a5f1d3e 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Oct 24, 2023
@actions-user
site deploy
449270f 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
@actions-user
site deploy
9fcec7e 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Nov 7, 2023
@actions-user
site deploy
bc30d46 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Nov 14, 2023
@actions-user
site deploy
d102fd1 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
@actions-user
site deploy
fd2a5f3 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Nov 28, 2023
@actions-user
site deploy
ef7ef8e 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Dec 5, 2023
@actions-user
site deploy
cf2f1e3 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Dec 12, 2023
@actions-user
site deploy
737a223 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
@actions-user
site deploy
0613dc8 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Dec 26, 2023
@actions-user
site deploy
173b93d 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Jan 2, 2024
@actions-user
site deploy
0816280 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Jan 9, 2024
@actions-user
site deploy
32dbc28 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
github-actions bot pushed a commit that referenced this pull request Jan 16, 2024
@actions-user
site deploy
71d0d84 
Auto-generated via {sandpaper}
Source  : 5a06d96
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-08-02 18:31:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 74b5f59
Branch  : main
Author  : henry senyondo <henrykironde@gmail.com>
Time    : 2023-08-02 18:29:48 +0000
Message : Merge pull request #362 from JCSzamosi/clarify-contrib-links

Clarify issues links in CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrykironde henrykironde henrykironde left review comments

@zkamvar zkamvar zkamvar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JCSzamosi @henrykironde @zkamvar