This repository has been archived by the owner on May 19, 2023. It is now read-only.
Bypass SSL certification for downloading. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the http://www.nano-editor.org/dist/v2.2/NT/nano-2.2.6.zip download fails with "error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed"
|
Thanks for this simple fix. I think that's good enough for now. I do hope to get some comments on #56 --the lack of discussion is why I haven't moved forward on an improved installer yet. |
mickley
added a commit
to sorgerlab/2016-10-06-harvard
that referenced
this pull request
Oct 6, 2016
This is built on 32-bit Python/py2exe and will work with 32-bit Windows, fixing [this issue](swcarpentry/windows-installer#49). Also incorporates [this unmerged pull request](swcarpentry/windows-installer#59), which allows nano to be downloaded over SSL.
|
I was able to successfully build the installer with this code change. This works correctly on Windows8 and Windows10. |
|
We've been facing this issue with Windows 10 installation at a workshop in Sacramento. +1 to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may not be the best way to solve this issue but we need it quickly or participants cannot use nano (we'd have to use vim or notepad instead).
Otherwise the http://www.nano-editor.org/dist/v2.2/NT/nano-2.2.6.zip
download fails with
"error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed"