DownMix Node Augmentation #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_and_op_overload
| @@ -171,6 +171,7 @@ list(APPEND SOURCES | |||
| source/tensor/TensorMulScalar.cpp | |||
| source/tensor/TensorAddTensor.cpp | |||
| source/tensor/SequenceRearrange.cpp | |||
| source/tensor/Downmix.cpp | |||
There was a problem hiding this comment.
Can we add this in alphabetical order
| #define VX_KERNEL_RPP_NOP_NAME "org.rpp.Nop" | ||
| #define VX_KERNEL_RPP_RESIZE_NAME "org.rpp.Resize" | ||
| #define VX_KERNEL_RPP_SEQUENCEREARRANGE_NAME "org.rpp.SequenceRearrange" | ||
| #define VX_KERNEL_RPP_DOWNMIX_NAME "org.rpp.Downmix" |
There was a problem hiding this comment.
Please maintain alphabetical order
| @@ -158,6 +158,7 @@ extern "C" | |||
| VX_KERNEL_RPP_RESAMPLE = VX_KERNEL_BASE(VX_ID_AMD, VX_LIBRARY_RPP) + 0x81, | |||
| VX_KERNEL_RPP_TENSORMULSCALAR = VX_KERNEL_BASE(VX_ID_AMD, VX_LIBRARY_RPP) + 0x82, | |||
| VX_KERNEL_RPP_TENSORADDTENSOR = VX_KERNEL_BASE(VX_ID_AMD, VX_LIBRARY_RPP) + 0x83, | |||
| VX_KERNEL_RPP_DOWNMIX = VX_KERNEL_BASE(VX_ID_AMD, VX_LIBRARY_RPP) + 0x84, | |||
There was a problem hiding this comment.
Add in alphabetical order
| @@ -1526,7 +1526,10 @@ extern "C" | |||
| TODO: Add the params | |||
| */ | |||
| SHARED_PUBLIC vx_node VX_API_CALL vxExtRppTensorAddTensor(vx_graph graph, vx_tensor pSrc1, vx_tensor pSrc2, vx_tensor pDst, vx_tensor srcRoi, vx_tensor dstRoi, vx_uint32 nbatchSize); | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
Please ensure you add the Doxygen comments for all the audio augmentations in respective PR
| @@ -120,6 +120,7 @@ static vx_status VX_CALLBACK validateSpectrogram(vx_node node, const vx_referenc | |||
| vx_enum tensor_datatype; | |||
| STATUS_ERROR_CHECK(vxQueryTensor((vx_tensor)parameters[2], VX_TENSOR_NUMBER_OF_DIMS, &num_tensor_dims, sizeof(num_tensor_dims))); | |||
| if(num_tensor_dims < 3) return ERRMSG(VX_ERROR_INVALID_DIMENSION, "validate: Spectrogram: tensor: #2 dimensions=%lu (must be greater than or equal to 4)\n", num_tensor_dims); | |||
|
|
|||
There was a problem hiding this comment.
Why this change added in this pipeline?
| #include "graph.h" | ||
|
|
||
| class DownmixNode : public Node | ||
| { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final Audio PR with downMix augmentation support