Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow older versions of gettext #51

Merged
merged 1 commit into from
Nov 4, 2017
Merged

Allow older versions of gettext #51

merged 1 commit into from
Nov 4, 2017

Conversation

tresf
Copy link
Contributor

@tresf tresf commented Nov 2, 2017

Gettext 0.18.3 works just fine and lowers the requirements for older build systems.
@hartwork FYI, partially reverts 01c7745.
Tested on Ubuntu 14.04.

Gettext 0.18.3 works just fine and lowers the requirements for older build systems.
@hartwork FYI, partially reverts 01c7745.  
Tested on Ubuntu 14.04.
@hartwork
Copy link
Contributor

hartwork commented Nov 2, 2017

Please check #25 for why I bumped to gettext 0.19.x back then. 0.18.3 may still do, but I rely on you for testing.

@tresf
Copy link
Contributor Author

tresf commented Nov 2, 2017

@hartwork:

ubuntu@ubuntu1404:~/ladspa$ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=14.04
DISTRIB_CODENAME=trusty
DISTRIB_DESCRIPTION="Ubuntu 14.04.5 LTS"
ubuntu@ubuntu1404:~/ladspa$ gettext --version
+gettext (GNU gettext-runtime) 0.18.3
Copyright (C) 1995-1997, 2000-2007 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Written by Ulrich Drepper.

Mine (red, pretend they're plusses) versus yours (green)

+ Copying file ABOUT-NLS
  Copying file config.rpath
- Creating directory m4
  Copying file m4/codeset.m4
+ Copying file m4/extern-inline.m4
  Copying file m4/fcntl-o.m4
  Copying file m4/gettext.m4
  Copying file m4/glibc2.m4
  Copying file m4/glibc21.m4
  Copying file m4/iconv.m4
  Copying file m4/intdiv0.m4
  Copying file m4/intl.m4
  Copying file m4/intldir.m4
  Copying file m4/intlmacosx.m4
  Copying file m4/intmax.m4
  Copying file m4/inttypes-pri.m4
  Copying file m4/inttypes_h.m4
  Copying file m4/lcmessage.m4
  Copying file m4/lib-ld.m4
  Copying file m4/lib-link.m4
  Copying file m4/lib-prefix.m4
  Copying file m4/lock.m4
  Copying file m4/longlong.m4
  Copying file m4/nls.m4
  Copying file m4/po.m4
  Copying file m4/printf-posix.m4
  Copying file m4/progtest.m4
  Copying file m4/size_max.m4
  Copying file m4/stdint_h.m4
  Copying file m4/threadlib.m4
  Copying file m4/uintmax_t.m4
  Copying file m4/visibility.m4
  Copying file m4/wchar_t.m4
  Copying file m4/wint_t.m4
  Copying file m4/xsize.m4
  Copying file po/Makefile.in.in
  Copying file po/Makevars.template
  Copying file po/Rules-quot
  Copying file po/boldquot.sed
  Copying file po/en@boldquot.header
  Copying file po/en@quot.header
  Copying file po/insert-header.sin
  Copying file po/quot.sed
- Copying file po/remove-potcdate.sin
  • ABOUT-NLS has since been removed by you in 236bda4. Edit: Sorry, referencing an un-merged pull request. I'm not sure why we don't have this file.
  • remove-potcdate.sin I can't find any info on, but here's a mirror.
  • extern-inline.m4 I'm having trouble locating as well.

Edit: The rest of the files seem to be there so if this reversion to older gettext causes a bug, I would need help identifying it.

I don't know this build system (at all) so I hope this provides enough information for a decision. If not, let me know and I can dig some more information.

@hartwork
Copy link
Contributor

hartwork commented Nov 2, 2017

For extern-inline.m4: http://git.savannah.gnu.org/cgit/gettext.git/tree/gettext-runtime/m4/extern-inline.m4

@swh swh merged commit 884bbb1 into swh:master Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants