Skip to content

Conversation

@swhitty
Copy link
Owner

@swhitty swhitty commented Oct 22, 2023

SFSymbols using fill-rule: evenOdd need to be converted to non zero winding rule only when filling.

When a path is stroked — expanded on Darwin platforms using with replacePathWithStrokedPath(), then no conversion is required.

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e92302a) 85.33% compared to head (bd3ea7f) 85.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   85.33%   85.34%           
=======================================
  Files          77       77           
  Lines        7024     7026    +2     
=======================================
+ Hits         5994     5996    +2     
  Misses       1030     1030           
Files Coverage Δ
SwiftDraw/Renderer.SFSymbol.swift 85.28% <92.30%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swhitty swhitty merged commit 33792d9 into main Oct 22, 2023
@swhitty swhitty deleted the only-wind-fill-paths branch October 22, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant