Skip to content

Conversation

@swhitty
Copy link
Owner

@swhitty swhitty commented May 24, 2024

Fixes a defect where Image tags were ignoring any input sizes and positions.
#40

Positions and Sizes and now respected but are not optional and default to the size within the bitmap image if not provided within the SVG.

fix

@codecov
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 92.53731% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 84.07%. Comparing base (2823463) to head (040031e).

Files Patch % Lines
SwiftDraw/Renderer.CGText.swift 0.00% 3 Missing ⚠️
SwiftDraw/LayerTree.CommandGenerator.swift 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   84.04%   84.07%   +0.02%     
==========================================
  Files          77       77              
  Lines        5391     5426      +35     
==========================================
+ Hits         4531     4562      +31     
- Misses        860      864       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swhitty swhitty merged commit 5bda33c into main May 24, 2024
@swhitty swhitty deleted the fix-image-size branch May 24, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants