Account for poor formatting of error messages by SPM plugin compilation failures.

[dabrahams]

Sorry I didn't deal with this earlier. Very similar to #191, I have the following to deal with this SPM issue. It would be awesome if swift-mode could handle this for me.

(defun dwa/spm-plugin-compilation-error-patch ()
  "Update the gnu error message format to account for https://github.com/apple/swift-package-manager/issues/6862."
  (let ((e (cdr (assoc 'gnu compilation-error-regexp-alist-alist)))
	(prefix "\\(?:error: plugin compilation \\)?"))

    (unless
	;; Attempt to make this modification idempotent
	(or (string-match (regexp-quote prefix) (car e))
	    ;; Don't try anything unless the regexp starts with "^".
	    (not (equal (substring (car e) 0 1) "^"))
      ; Shadow the existing alist entry; no need to modify it.
      (add-to-list
       'compilation-error-regexp-alist-alist
       ;; Inject the prefix after the "^"
       `(gnu . ,(cons (concat "^" prefix (substring (car e) 1)) (cdr e))))))))

(use-package swift-mode
  :custom
  (swift-mode:basic-offset 2)
  :mode ("\\.swift\\.gyb" . swift-mode)
  :init
  ;; Diagnostic parsing
  (require 'compile)
  (require 'compilation-smart-find)

  (add-hook 'swift-mode-hook (lambda () (setq tab-width 2)))
  (dwa/spm-plugin-compilation-error-patch)
  (dwa/swift-mode-lsp-setup))

[taku0]

We might fix this by updating swift-mode:swift-testing-command-regexp to something like "\\<swift \\(?:test\\|package\\|build\\)\\>". Are there any other commands to apply the special handling of filenames?

[dabrahams]

If you're asking me, I'm sorry, I don't know what you mean… and I'm guessing that I don't know the answer either.

[taku0]

swift-mode sets compilation-process-setup-function to hook the compile command. When the command-line string matches the regular expression swift-mode:swift-testing-command-regexp, special filename handling is activated. The current pattern, "\\<swift test\\>", checks if the command-line string contains swift test. I propose extending this pattern to also recognize swift package and swift build commands. Are there any other commands that should be included in the pattern?

[dabrahams]

Probably any swift commands should be included. You might have a build tool that generated the documentation using sourcekit; it will emit the same diagnostics. Who knows which other commands they will support. Unfortunately trying to be conservative is probably going to backfire; I used to invoke swift using a little wrapper script called ‘s’. I don’t think any of the other patterns are trying to be so selective, probably for good reasonSent from my iPhoneOn May 20, 2025, at 3:57 AM, taku0 ***@***.***> wrote: taku0 left a comment (swift-emacs/swift-mode#195) swift-mode sets compilation-process-setup-function to hook the compile command. When the command-line string matches the regular expression swift-mode:swift-testing-command-regexp, special filename handling is activated. The current pattern, "\\<swift test\\>", checks if the command-line string contains swift test. I propose extending this pattern to also recognize swift package and swift build commands. Are there any other commands that should be included in the pattern? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[taku0]

At least, including swift run would be questionable, and swift repl would be meaningless. swift-mode:swift-testing-command-regexp is a customizable variable, so it doesn't need to be comprehensive as long as it provides a reasonable default.

My special filename handling has both a significant performance penalty and functional side effects for non-Swift files, so we have to enable it only for Swift commands.

[taku0]

Fixed by 839e46d.