Flash programming bugfixes #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash_check_erase_and_write() didn't calculate the last page to erase correctly, because it was written like if the len argument was in bytes instead of 2-byte words. This bug lead to pages not being erased properly when downloading a hex file whose entries span page boundaries. Signed-off-by: Jonas Norling <jonas.norling@greeneggs.se>
When calling flash_erase_page() with a too high page number it wraps around and starts erasing bootloader pages. Add a check to avoid that. Signed-off-by: Jonas Norling <jonas.norling@greeneggs.se>
This fixes a bug that's exposed when plugging in the device in a Windows 10 host. After enumeration it sends a SET CONTROL LINE STATE request followed by a SET LINE CODING request. The former has 0 bytes payload data, which caused the USB device to stall the latter transaction. This happened because USBCS0_DATA_END was set in usb_ep0_setup (indicating no data expected for this transaction), and then again in usb_ep0_flush (indicating no data expected in the _next_ transaction). The bit remained set, causing the MCU to stall the following OUT transaction. This didn't cause problems on Linux because it has a different access pattern. The fix is to call usb_ep0_flush() only when needed, i.e. when we're in USB_EP0_DATA_IN state and there is data to send.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for flash erase, and cherry-picking a fix from @AdamLaurie.